Skip to content

fix: remove invalid BASS_Free import from AudioPlayer#4

Merged
Orinks merged 10 commits intomainfrom
dev
Feb 1, 2026
Merged

fix: remove invalid BASS_Free import from AudioPlayer#4
Orinks merged 10 commits intomainfrom
dev

Conversation

@Orinks
Copy link
Owner

@Orinks Orinks commented Feb 1, 2026

Summary

Fixes the BASS_Free import error that was breaking all tests.

Changes

  • Removed invalid BASS_Free import from sound_lib.main (symbol doesn't exist)
  • BASS cleanup is now handled automatically by sound_lib's Output destructor
  • Fixed lint issues: unused imports, == False comparisons, E402 noqa

Testing

  • Import now works correctly (verified with mock)
  • Lint passes: ruff check .

Closes #2

Orinks added 10 commits October 16, 2025 21:53
- Documented main/dev branch structure
- Provided feature branch workflow
- Included git best practices
- Ready for Phase 3 development
Co-Authored-By: Memex <noreply@memex.tech>
- Clarified that briefcase dev MUST run from accessibletalkingclock/ directory
- Added example of wrong vs correct briefcase dev execution
- Emphasized venv is at project root but briefcase needs app directory
- Updated after threading fixes troubleshooting session
Co-Authored-By: Memex <noreply@memex.tech>
- Created resources/sounds/ directory with three soundpacks (classic, nature, digital)
- Added .gitkeep files to preserve empty directories
- Created ATTRIBUTIONS.md template for audio file credits
- Added Phase 3 implementation plan and tasks
Co-Authored-By: Memex <noreply@memex.tech>
- Wrote 13 unit tests for Soundpack class (test_soundpack.py)
- Implemented Soundpack class with loading, validation, path retrieval
- Implemented SoundpackManager for discovering and managing soundpacks
- All tests passing (13/13)
- Added sound recommendations document with curated CC0 sounds from Freesound
- Updated tasks to mark task 1 complete
Co-Authored-By: Memex <noreply@memex.tech>
- Created PHASE3_PROGRESS.md with detailed status update
- Updated tasks.json to mark tasks 1-3 as completed
- Documented next steps for audio file acquisition
Co-Authored-By: Memex <noreply@memex.tech>
- Initialize SoundpackManager in app.startup() with default 'classic' soundpack
- Update soundpack dropdown to dynamically populate from discovered soundpacks
- Implement _on_soundpack_change() to load selected soundpack
- Update _on_test_chime() to play current soundpack's hour chime instead of test sound
- Add _play_chime() helper method for playing any chime type from current soundpack
- Update clock update task to trigger automatic chimes at correct times:
  * Hour chime at :00 if hourly switch enabled
  * Half-hour chime at :30 if half-hour switch enabled
  * Quarter-hour chime at :15 and :45 if quarter-hour switch enabled
- Add _last_chime_time tracking to prevent duplicate chimes per minute
- All 39 tests passing (16 audio + 13 soundpack + 10 integration)
- Manual testing confirms all three soundpacks (classic, digital, nature) work correctly
Phase 3 Tasks 5-6 complete: UI integration and automatic chiming functional
Co-Authored-By: Memex <noreply@memex.tech>
- Created comprehensive summary of implementation (PHASE3_TASKS_5_6_SUMMARY.md)
- Created NVDA testing guide with detailed checklist (NVDA_TESTING_GUIDE.md)
- Updated task list with final testing task for user
Ready for user NVDA accessibility testing
Co-Authored-By: Memex <noreply@memex.tech>
User confirmed all accessibility features working correctly with NVDA:
- All controls keyboard accessible
- Tab navigation logical
- Status messages announced
- Soundpack switching functional
- Automatic chiming working at correct times
Phase 3 complete - ready to merge to dev
Co-Authored-By: Memex <noreply@memex.tech>
Phase 3 successfully completed and merged to dev:
- All 6 tasks complete
- 39 tests passing
- NVDA accessibility verified
- Three soundpacks fully functional
- Automatic chiming working correctly
Ready for Phase 4: Settings Persistence
Co-Authored-By: Memex <noreply@memex.tech>
- BASS_Free doesn't exist in sound_lib.main
- sound_lib handles cleanup automatically via Output destructor
- Also fixed lint issues (unused imports, == False comparisons)

Closes #2
@Orinks Orinks merged commit 2c92026 into main Feb 1, 2026
5 checks passed
@Orinks Orinks deleted the dev branch February 1, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: BASS_Free import error breaks tests

1 participant